Skip to content

handling whatsapp cloud extra 9 contact number#448

Open
rasoro wants to merge 1 commit into
nyaruka:mainfrom
weni-ai:fix-wac-extra-9
Open

handling whatsapp cloud extra 9 contact number#448
rasoro wants to merge 1 commit into
nyaruka:mainfrom
weni-ai:fix-wac-extra-9

Conversation

@rasoro

@rasoro rasoro commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

This PR is related to this #437 which was also discussed here #433

@codecov

codecov Bot commented Jul 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #448 (6ec941e) into main (57732ae) will decrease coverage by 0.01%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   72.31%   72.30%   -0.02%     
==========================================
  Files          95       95              
  Lines       12565    12582      +17     
==========================================
+ Hits         9087     9097      +10     
- Misses       2850     2855       +5     
- Partials      628      630       +2     
Impacted Files Coverage Δ
handlers/facebookapp/facebookapp.go 81.54% <56.25%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57732ae...6ec941e. Read the comment docs.

@norkans7

Copy link
Copy Markdown
Contributor

I wondering if we really need to use this as now we can just send by phone number

https://developers.facebook.com/docs/whatsapp/cloud-api/reference/messages#message-object

and soon no WA ID will be used at all even for on-prem https://developers.facebook.com/docs/whatsapp/on-premises/reference/contacts

Was the issue reproduced with WhatsApp Cloud before adding this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants